359 Commits

Author	SHA1	Message	Date
Deukhoofd	5cd5a634e2	Further memory fixes for getting HitData in ExecutingAttack.	2020-08-04 12:45:11 +02:00
Deukhoofd	f38161f573	Fixed issue where hitdata read wrong memory.	2020-08-04 12:22:05 +02:00
Deukhoofd	08ef84f6d6	Defensive programming.	2020-08-03 17:44:29 +02:00
Deukhoofd	93b3847b31	Revert "Disable EventHook system for now for testing." ... This reverts commit 84e03021	2020-08-03 17:28:43 +02:00
Deukhoofd	84e030213d	Disable EventHook system for now for testing.	2020-08-02 10:14:56 +02:00
Deukhoofd	d55a9e8494	Add more assertions to prevent segfaults.	2020-08-02 09:52:11 +02:00
Deukhoofd	1b9da9a721	Added more security to EventHook.	2020-08-01 11:34:25 +02:00
Deukhoofd	301f9b9656	Removed StringView initialization, and use the default uninitialized pointer for it.	2020-08-01 10:34:40 +02:00
Deukhoofd	670abd7229	Fixed Segfault when overriding talent.	2020-08-01 10:27:46 +02:00
Deukhoofd	fa5184ad77	Tweaks for EventHook.	2020-07-31 19:52:12 +02:00
Deukhoofd	c3de280ebb	Fixes for EventHook corruptions, unit tests for EventHooks.	2020-07-31 18:39:47 +02:00
Deukhoofd	0eaae43444	Reworked event hook to a system with pre-allocated memory, owned by the battle. This deals with cleaning up event data memory.	2020-07-31 16:19:39 +02:00
Deukhoofd	3e8f9340f3	Dont delete events after triggering the event listener. Once they're in the event listeners hands, it's their responsibility to properly clean up the memory.	2020-07-31 15:47:18 +02:00
Deukhoofd	bd7ecb6b33	More work on exceptions.	2020-07-31 14:17:38 +02:00
Deukhoofd	9c93ca6995	Fixed exception messages being wrong.	2020-07-31 11:23:23 +02:00
Deukhoofd	5a41208fdb	Further clearer error handling.	2020-07-31 10:45:20 +02:00
Deukhoofd	b56226076e	Fixed issue where multiple targets would cause the same target to be hit over and over again.	2020-07-30 20:15:58 +02:00
Deukhoofd	b3b9698831	More clearer exception messages.	2020-07-30 20:15:27 +02:00
Deukhoofd	13c4609cdd	Tweaks for exception handling.	2020-07-28 19:37:03 +02:00
Deukhoofd	e2e706693b	Clearer errors for C Interface.	2020-07-28 17:22:43 +02:00
Deukhoofd	1d03adf0d1	Implements replacement attack when an attack can't be used anymore, adds clearer exception handling.	2020-07-26 18:00:58 +02:00
Deukhoofd	36f1e5beeb	Further work on better exceptions.	2020-07-26 17:41:11 +02:00
Deukhoofd	a4bb8864a0	When creating a CreatureParty with a size, don't just reserve the space, but append nullptr as well.	2020-07-26 16:08:41 +02:00
Deukhoofd	436e68293e	Support for passing a random seed.	2020-07-26 10:16:25 +02:00
Deukhoofd	e6f84f182a	Add Creature getter for the library.	2020-07-25 15:02:11 +02:00
Deukhoofd	8f921ce89b	Add support for swapping in and out of a party.	2020-07-25 14:35:13 +02:00
Deukhoofd	be82abeece	Change nickname to string from string_view.	2020-07-19 12:15:14 +02:00
Deukhoofd	367ed7fcbb	Cleanup CMake file.	2020-07-17 13:12:21 +02:00
Deukhoofd	5032377554	Remove Random passes by pointer.	2020-07-12 15:26:00 +02:00
Deukhoofd	c6974b6b5b	Adds getter for Script for ExecutingAttack. Mostly useful for unit tests etc.	2020-07-04 18:13:36 +02:00
Deukhoofd	772619db0f	Changed LoadScript to StringView.	2020-06-26 18:23:40 +02:00
Deukhoofd	48639eeee5	Update to new Arbutils	2020-06-26 17:08:23 +02:00
Deukhoofd	f50f76e993	Move priority scripthook to more sensible place in turn flow.	2020-06-20 19:51:34 +02:00
Deukhoofd	b3366f7b58	Script hook for changing priority.	2020-06-20 19:44:41 +02:00
Deukhoofd	add77325a4	Several additional checks to ensure battle does not finish turn when ended.	2020-06-12 16:48:49 +02:00
Deukhoofd	fd1c6e9a0a	If no side is still alive, mark battle as inconclusive ended.	2020-06-12 16:25:21 +02:00
Deukhoofd	32bb641f75	Fixed issue with underflow in ScriptAggregator.	2020-06-12 15:49:37 +02:00
Deukhoofd	3358bf7378	Fixed comparing int32_t with uint32_t.	2020-06-10 14:46:45 +02:00
Deukhoofd	c8314d6018	Support for changing variants.	2020-06-10 14:39:20 +02:00
Deukhoofd	fddf2cabab	Rework ScriptIterator to jump to first value on reset.	2020-06-05 18:06:45 +02:00
Deukhoofd	9e7607338f	Moved Creature types to creature itself, instead of using the variant types.	2020-06-05 16:38:27 +02:00
Deukhoofd	3c5b3d5c03	Fixed potential reaching end of function.	2020-06-05 15:42:28 +02:00
Deukhoofd	66379bfa65	Initial support for handling multi target attacks.	2020-06-05 15:32:05 +02:00
Deukhoofd	f463ba8496	Simplify check whether mon is on battle field.	2020-06-05 14:35:23 +02:00
Deukhoofd	44de4a0799	Use std::algorithm for Battle::CreatureInField	2020-06-05 14:15:20 +02:00
Deukhoofd	57e8595bdf	Make ExecutingAttack creature list a raw C array, as this is a hot spot and could use some optimization.	2020-06-04 21:58:28 +02:00
Deukhoofd	657d646fda	Make the last couple classes use smart pointers.	2020-06-02 18:30:37 +02:00
Deukhoofd	7262ae9e8b	Make ExecutingAttack use smart pointers.	2020-06-02 18:02:37 +02:00
Deukhoofd	a5a613ba5c	Make CreateCreature use smart pointers.	2020-06-02 17:19:23 +02:00
Deukhoofd	62583ecb17	Make Creature use smart pointers.	2020-06-02 16:20:47 +02:00
Deukhoofd	1ef50fd3a6	Use unique pointers in scriptset.	2020-06-02 15:03:31 +02:00
Deukhoofd	23e2bc73bc	Style fixes.	2020-06-02 14:14:24 +02:00
Deukhoofd	e8650e2a03	Fixed build error.	2020-06-02 14:02:32 +02:00
Deukhoofd	e4b9550efa	Make all individual scripts smart pointers.	2020-06-02 13:43:44 +02:00
Deukhoofd	dba1275813	Move ScriptIterator reset to get call instead of inside Macro.	2020-06-02 13:21:23 +02:00
Deukhoofd	f898698f49	Use smart pointers for BattleSide.	2020-06-02 13:06:24 +02:00
Deukhoofd	49e8ff055d	Use smart pointer for BattleParty.	2020-06-02 12:16:26 +02:00
Deukhoofd	18203138d1	Use algorithm for IsResponsibleForIndex check.	2020-06-02 12:14:49 +02:00
Deukhoofd	69f6a89c0d	Make CreatureParty use smart pointers.	2020-05-31 19:04:40 +02:00
Deukhoofd	01f6e59cb6	Make battle class fields all smart pointers.	2020-05-31 19:01:45 +02:00
Deukhoofd	29cb4eac37	Make ChoiceQueue use smart pointers.	2020-05-31 18:00:39 +02:00
Deukhoofd	ff181204ae	Make LearnedAttack of Creature a smart pointer.	2020-05-31 17:26:39 +02:00
Deukhoofd	a7069a5960	Ensure Attack script is deleted when not taken by ExecutingAttack.	2020-05-29 20:05:05 +02:00
Deukhoofd	20be2815ce	Revert "Clean up choices if they can't be used." ... This reverts commit 04cef8b6	2020-05-29 19:29:25 +02:00
Deukhoofd	04cef8b6e2	Clean up choices if they can't be used.	2020-05-29 19:25:46 +02:00
Deukhoofd	d51919c74f	Make ExecutingAttack a local variable while being used, to ensure it's always cleaned up.	2020-05-29 18:49:48 +02:00
Deukhoofd	a9740cb1eb	Fixed memory leak in ExecutingAttack.	2020-05-27 18:29:52 +02:00
Deukhoofd	fcc6f2214e	Make ExecutingAttack have raw pointer array HitData, instead of a List. This is a very hot segment of code, and removing surrounding abstractions can give us a decent amount of performance.	2020-05-27 18:26:09 +02:00
Deukhoofd	90e7a699bc	Remove const qualification of ScriptResolver.	2020-05-26 20:53:06 +02:00
Deukhoofd	25f65eb47b	Update to newer Arbutils version.	2020-05-26 18:31:06 +02:00
Deukhoofd	d746b3ecce	Make staticlib in battle library an unique ptr.	2020-05-26 16:38:55 +02:00
Deukhoofd	0125215007	Style fixes	2020-05-26 16:35:01 +02:00
Deukhoofd	16b67b0d54	Make most of the battle library use unique_ptr.	2020-05-26 15:11:04 +02:00
Deukhoofd	e46117ea06	Fixes DataLibrary not having correct const definitions.	2020-05-26 15:02:41 +02:00
Deukhoofd	aba56d2fdd	Make Attack secondary effect a unique_ptr.	2020-05-26 14:41:43 +02:00
Deukhoofd	8418c814b4	Make SpeciesVariants smart pointers.	2020-05-26 14:35:18 +02:00
Deukhoofd	36208da2fb	Remove shared_ptr, instead use borrowed_ptr to more accurately depict ownership of the objects in the BaseLibraries.	2020-05-26 14:13:30 +02:00
Deukhoofd	d82792e27a	Make BaseLibraries use shared_ptr.	2020-05-24 20:57:22 +02:00
Deukhoofd	b17c0648ff	Make DataLibrary use unique_ptr.	2020-05-24 19:01:47 +02:00
Deukhoofd	c056ddc6b3	Adds getter for parties to battle.	2020-05-24 12:57:12 +02:00
Deukhoofd	2e860192c7	Support for blocking a creature from gaining experience, don't give experience when a creature is fainted.	2020-05-20 15:18:27 +02:00
Deukhoofd	94d9d4f3d2	Performance improvement for running turns by reducing the number of lookups for the hitdata.	2020-04-25 20:20:30 +02:00
Deukhoofd	f602ea9358	Fixed Windows build issue.	2020-04-25 20:13:46 +02:00
Deukhoofd	7fd3687564	Cleanup of ExecutingAttack, removing TargetData, and reducing the number of allocations needed.	2020-04-25 20:09:20 +02:00
Deukhoofd	8eb22ad68d	Pass HitData as reference to damage calculation library, to prevent multiple lookup.	2020-04-25 16:51:10 +02:00
Deukhoofd	864a9d933d	Inlined get stats from Creature. These are frequently called one line methods.	2020-04-25 16:15:27 +02:00
Deukhoofd	0e874346bb	Pass ExecutingAttack values by reference instead of pointer.	2020-04-25 16:04:17 +02:00
Deukhoofd	734d056449	Performance improvement for collecting scripts, by reserving size in ScriptSource.	2020-04-25 11:33:25 +02:00
Deukhoofd	1eb751538d	Updated to latest Arbutils.	2020-04-25 10:41:15 +02:00
Deukhoofd	dd668f2b1c	Cleanup of ScriptAggregator class.	2020-04-23 23:23:58 +02:00
Deukhoofd	3a11bba913	Rework ScriptAggregator so it only needs to be created once, and can then be reset.	2020-04-23 19:57:45 +02:00
Deukhoofd	742d0c772c	Handling for tie breaking	2020-04-22 23:09:54 +02:00
Deukhoofd	1709617e10	Remove tie breaking by randomness. This caused issues with sorting.	2020-04-22 23:03:16 +02:00
Deukhoofd	97fa37ea7d	Implements clamped statistics for stat boost.	2020-04-22 21:48:00 +02:00
Deukhoofd	75baf19ebd	Cleanup	2020-04-22 21:20:07 +02:00
Deukhoofd	d2cf26e950	Fixed issue where attack with 1 use remaining couldn't be used.	2020-04-22 15:03:09 +02:00
Deukhoofd	ddbf4c23b8	Fix for compilation issue when using NO_ASSERT.	2020-04-22 12:54:11 +02:00
Deukhoofd	83f427368e	Pass LearnedAttack list to creature by reference.	2020-04-21 14:44:57 +02:00
Deukhoofd	a54459cc57	Fixes for effect.	2020-04-21 12:31:53 +02:00
Deukhoofd	3dcefebee7	Add ChangeEffectiveness script hook.	2020-04-19 13:07:28 +02:00
Deukhoofd	88d55998d0	Change DamageSource enum to Arbutils Enum.	2020-04-19 12:59:25 +02:00
Deukhoofd	a200c7cde8	Make Battle fields protected instead of private.	2020-04-18 15:22:38 +02:00
Deukhoofd	2e5d463e45	Throw clean exception when no volatile script is found when adding one.	2020-04-11 00:22:08 +02:00
Deukhoofd	04bf061115	Removed OnStatusMove hook, now just uses OnSecondaryEffect hook.	2020-04-10 23:06:19 +02:00
Deukhoofd	5ac2b7b3c9	Turn SecondaryEffect class into pointer type, owned by AttackData.	2020-04-10 22:17:48 +02:00
Deukhoofd	e934e13950	Replace void* for script parameter with EffectParameter class.	2020-04-10 17:54:45 +02:00
Deukhoofd	1537a5f316	Initialize script with move effect parameters.	2020-04-10 17:18:19 +02:00
Deukhoofd	49e0f00237	Initialize CreateCreature with ConstString instead of std::string.	2020-04-10 16:44:25 +02:00
Deukhoofd	88eda6ef94	Update to new version of Arbutils.	2020-04-09 18:19:21 +02:00
Deukhoofd	70fc8d2d5f	Add C interface for ExecutingAttack.	2020-04-06 17:05:32 +02:00
Deukhoofd	340520e0e3	Reworks attack scripts to handle effect chance and effect name through data files.	2020-04-06 12:02:29 +02:00
Deukhoofd	e2675d06fb	C interface for Battle Random.	2020-04-04 18:24:59 +02:00
Deukhoofd	3dd5aeffd8	C interface for Battle Side.	2020-04-04 17:03:06 +02:00
Deukhoofd	3429f1647c	Made C Interface for BattleLibrary constructor try.	2020-04-04 13:42:06 +02:00
Deukhoofd	1e0d00d3b7	Revert "Use smart pointers for basic libraries." ... This reverts commit 214ff819	2020-04-04 13:37:06 +02:00
Deukhoofd	91bea44113	Added LearnedAttack C Interface.	2020-04-04 13:36:13 +02:00
Deukhoofd	214ff81992	Use smart pointers for basic libraries.	2020-03-26 22:46:14 +01:00
Deukhoofd	b5894ea8f2	Added C Interface for Script.	2020-03-25 19:47:37 +01:00
Deukhoofd	7ce3e6940d	Rework for C Interfaces to handle exceptions a bit better.	2020-03-25 19:09:17 +01:00
Deukhoofd	27288563cd	Replace most collections with Arbutils collections for more safety.	2020-03-22 19:21:40 +01:00
Deukhoofd	f190121e74	More Assertions to validate state correctness.	2020-03-22 15:35:58 +01:00
Deukhoofd	475392f9b6	Fixed issue where base stats of a variant got corrupted.	2020-03-22 15:25:38 +01:00
Deukhoofd	899e432271	Added lots of security using asserts.	2020-03-22 13:42:26 +01:00
Deukhoofd	970ca8ddd5	Fixed replacementattack not being complete.	2020-03-22 10:30:45 +01:00
Deukhoofd	a7b87ab4f8	Merge Core library into Library, as with its utility functionality merged into Arbutils, it's becoming less and less useful.	2020-03-22 10:11:53 +01:00
Deukhoofd	5672f2d2a7	Support for attack when other attacks can't be used in MiscLibrary.	2020-03-12 11:15:00 +01:00
Deukhoofd	7435a2a678	Turnchoices C Interface.	2020-03-11 12:22:13 +01:00
Deukhoofd	5a976e4031	Added display text event hook.	2020-03-09 17:43:36 +01:00
Deukhoofd	06336c64cd	Added canRevive parameter to Heal function, added Faint event.	2020-03-09 16:29:41 +01:00
Deukhoofd	3efd7a6974	Added C interface for EventData.	2020-03-09 11:12:24 +01:00
Deukhoofd	ce2fc320bd	Tweaks for Battle and ScriptSet, added Battle C interface.	2020-03-09 10:16:57 +01:00
Deukhoofd	1afb13cfd1	Added C Interface for BattleParty.	2020-03-08 15:19:19 +01:00
Deukhoofd	bbe99da0f0	Fixes and tweaks for CreatureParty, added C Interface.	2020-03-08 13:53:58 +01:00
Deukhoofd	1d18066bcc	Made Battle take battleparties as a pointer instead of value for external use.	2020-03-07 11:00:48 +01:00
Deukhoofd	e990c13109	Added Creature C Interface, misc fixes and changes for Creature.	2020-03-05 11:25:41 +01:00
Deukhoofd	e7d3c6afd4	Changed DamageLibrary to use appropriate integer types, instead of 'int'.	2020-03-04 18:28:14 +01:00
Deukhoofd	ea8afcd0b3	C interface for BattleLibrary.	2020-03-04 17:04:44 +01:00
Deukhoofd	81ae0e8454	Make Attack name a ConstString.	2020-03-02 15:29:42 +01:00
Deukhoofd	0c1580ade6	Reworked retrieving talent, new method is cleaner and harder to misunderstand.	2020-03-02 13:59:49 +01:00
Deukhoofd	5a05a2f4d3	Add ConstString to several other places where context isn't changed much during runtime.	2020-02-28 19:23:24 +01:00
Deukhoofd	412e0a4d63	Implements ConstString in several core places in the library, improving performance.	2020-02-27 18:23:23 +01:00
Deukhoofd	5e6572aca5	Move several classes from Core to Arbutils.	2020-02-26 13:51:16 +01:00
Deukhoofd	428b318baf	Mark ScriptSet.Has as const.	2020-02-23 16:20:11 +01:00
Deukhoofd	3802587313	Added HasVolatileScript function to Creature and Battle.	2020-02-23 16:17:57 +01:00
Deukhoofd	a606fbbc7b	Make basic Script class abstract, require implementation of GetName function.	2020-02-23 12:58:13 +01:00
Deukhoofd	5f891cd4ed	Added Remove Volatile functions for battle and creatures.	2020-02-23 11:11:47 +01:00
Deukhoofd	645ba95bbc	Performance improvements for battle and creature AddVolatileScript methods when passing a string as parameter. ... Instead of loading a script, then passing it to the ScriptSet class and checking if it already exists before invoking stack, we now check whether the ScriptSet has that script. If one already exists we just invoke stack on it, if not we continue to the process of creating a new script instance.	2020-02-22 16:01:01 +01:00
Deukhoofd	142889ad8a	Add functions to add volatile scripts to Creature.cpp.	2020-02-22 15:53:51 +01:00
Deukhoofd	32584ac406	Fixed Windows build.	2020-02-22 15:11:18 +01:00
Deukhoofd	442d6cd5b1	Added Helper function to ChoiceQueue to move a specific creature's choice up next.	2020-02-22 14:16:38 +01:00