Deukhoofd/CreatureLib
1
0 Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove Random passes by pointer.
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
Deukhoofd committed 2020-07-12 15:26:00 +02:00
1 parent abab1d0f9a
commit 5032377554
3 files changed
+4 -8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Battling/Models/CreateCreature.cpp
+1 -1
View File
@@ -35,7 +35,7 @@ Creature* CreateCreature::Create() {
auto variant = species->GetVariant(this->_variant);
Library::TalentIndex talent;
if (this->_talent.Empty()) {
talent = variant->GetRandomTalent(&rand);
talent = variant->GetRandomTalent(rand);
} else {
talent = variant->GetTalentIndex(this->_talent);
}
src/Library/BaseLibrary.hpp
+1 -5
View File
@@ -86,14 +86,10 @@ namespace CreatureLib::Library {
[[nodiscard]] size_t GetCount() const noexcept { return _values.Count(); }
inline ArbUt::BorrowedPtr<const T> GetRandomValue(ArbUt::Random rand = ArbUt::Random()) const noexcept {
inline ArbUt::BorrowedPtr<const T> GetRandomValue(ArbUt::Random& rand) const noexcept {
auto i = rand.Get(_listValues.Count());
return _values[_listValues[i]];
}
inline ArbUt::BorrowedPtr<const T> GetRandomValue(ArbUt::Random* rand) const noexcept {
auto i = rand->Get(_listValues.Count());
return _values[_listValues[i]];
}
};
}
src/Library/CreatureData/SpeciesVariant.hpp
+2 -2
View File
@@ -68,8 +68,8 @@ namespace CreatureLib::Library {
GetLearnableAttacks() const {
return _attacks;
}
[[nodiscard]] inline TalentIndex GetRandomTalent(ArbUt::Random* rand) const noexcept {
return TalentIndex(false, rand->Get(_talents.Count()));
[[nodiscard]] inline TalentIndex GetRandomTalent(ArbUt::Random& rand) const noexcept {
return TalentIndex(false, rand.Get(_talents.Count()));
}
[[nodiscard]] inline const ArbUt::List<ArbUt::StringView>& GetTalents() const { return _talents; }
[[nodiscard]] inline const ArbUt::List<ArbUt::StringView>& GetSecretTalents() const { return _secretTalents; }