Fixes all clippy warnings

src/dynamic_data/models/pokemon.rs

@@ -8,18 +8,17 @@ use parking_lot::RwLock;
 use crate::defines::{LevelInt, MAX_MOVES};
 use crate::dynamic_data::event_hooks::Event;
 use crate::dynamic_data::models::battle::Battle;
-use crate::dynamic_data::models::damage_source::DamageSource;
 use crate::dynamic_data::models::learned_move::{LearnedMove, MoveLearnMethod};
 use crate::dynamic_data::script_handling::{ScriptSource, ScriptSourceData, ScriptWrapper};
 use crate::dynamic_data::{DynamicLibrary, Script, ScriptCategory, ScriptContainer, ScriptSet, VolatileScriptsOwner};
-use crate::static_data::DataLibrary;
 use crate::static_data::Form;
 use crate::static_data::Gender;
 use crate::static_data::Item;
 use crate::static_data::Nature;
 use crate::static_data::Species;
+use crate::static_data::TypeIdentifier;
 use crate::static_data::{Ability, Statistic};
-use crate::static_data::{AbilityIndex, TypeIdentifier};
+use crate::static_data::{AbilityIndex, DataLibrary};
 use crate::static_data::{ClampedStatisticSet, StatisticSet};
 use crate::utils::Random;
 use crate::{script_hook, PkmnResult, StringKey};
@@ -344,10 +343,14 @@ impl<'own, 'library> Pokemon<'own, 'library> {
 
         let mut changed = false;
         let old_value = self.stat_boost.get_stat(stat);
-        if diff_amount > 0 {
-            changed = self.stat_boost.increase_stat(stat, diff_amount);
-        } else if diff_amount < 0 {
-            changed = self.stat_boost.decrease_stat(stat, -diff_amount);
+        match diff_amount.cmp(&0_i8) {
+            std::cmp::Ordering::Less => {
+                changed = self.stat_boost.decrease_stat(stat, -diff_amount);
+            }
+            std::cmp::Ordering::Greater => {
+                changed = self.stat_boost.increase_stat(stat, -diff_amount);
+            }
+            _ => {}
         }
         if changed {
             if let Some(battle) = self.get_battle() {
@@ -361,7 +364,7 @@ impl<'own, 'library> Pokemon<'own, 'library> {
             }
             self.recalculate_boosted_stats();
         }
-        return changed;
+        changed
     }
 
     /// The [individual values](https://bulbapedia.bulbagarden.net/wiki/Individual_values) of the Pokemon.
@@ -740,12 +743,20 @@ impl<'own, 'library> VolatileScriptsOwner<'own> for Pokemon<'own, 'library> {
     }
 }
 
+/// A source of damage. This should be as unique as possible.
+#[derive(Debug, Clone, Copy)]
+pub enum DamageSource {
+    /// The damage is done by a move.
+    MoveDamage = 0,
+    /// The damage is done by something else.
+    Misc = 1,
+}
+
 #[cfg(test)]
 pub mod test {
     use crate::dynamic_data::models::pokemon::Pokemon;
-    use crate::static_data::AbilityIndex;
-    use crate::static_data::DataLibrary;
     use crate::static_data::Gender;
+    use crate::static_data::{AbilityIndex, DataLibrary};
 
     #[test]
     fn construct_pokemon() {