Replace most panics in the core library with results

src/dynamic_data/flow/choice_queue.rs

@@ -160,6 +160,7 @@ impl ValueIdentifiable for ChoiceQueue {
 
 #[cfg(test)]
 #[allow(clippy::unwrap_used)]
+#[allow(clippy::indexing_slicing)]
 mod tests {
     use super::*;
     use crate::defines::LevelInt;

src/dynamic_data/flow/turn_runner.rs

@@ -213,7 +213,7 @@ impl Battle {
                 .library()
                 .static_data()
                 .types()
-                .get_effectiveness(hit_type, &target.types());
+                .get_effectiveness(hit_type, &target.types())?;
             script_hook!(
                 change_effectiveness,
                 executing_move,

src/dynamic_data/libraries/battle_stat_calculator.rs

@@ -147,6 +147,7 @@ impl ValueIdentifiable for Gen7BattleStatCalculator {
     }
 }
 #[cfg(test)]
+#[allow(clippy::indexing_slicing)]
 pub mod tests {
     use super::*;
 

src/dynamic_data/libraries/dynamic_library.rs

@@ -127,6 +127,7 @@ impl ValueIdentifiable for DynamicLibraryImpl {
 }
 
 #[cfg(test)]
+#[allow(clippy::indexing_slicing)]
 pub mod test {
     use super::*;
     use crate::dynamic_data::libraries::battle_stat_calculator::Gen7BattleStatCalculator;

src/dynamic_data/models/learned_move.rs

@@ -101,6 +101,7 @@ impl ValueIdentifiable for LearnedMove {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::static_data::tests::MockMoveData;

src/dynamic_data/models/pokemon.rs

@@ -421,7 +421,7 @@ impl Pokemon {
         }
 
         let form = self.form();
-        let ability = form.get_ability(self.ability_index);
+        let ability = form.get_ability(self.ability_index)?;
         Ok(self
             .library
             .static_data()

src/dynamic_data/models/pokemon_builder.rs

@@ -53,7 +53,7 @@ impl PokemonBuilder {
             .species()
             .get(&self.species)
             .ok_or(PkmnError::InvalidSpeciesName { species: self.species })?;
-        let form = species.get_default_form();
+        let form = species.get_default_form()?;
         let p = Pokemon::new(
             self.library,
             species,

src/dynamic_data/script_handling/script.rs

@@ -388,6 +388,8 @@ impl Clone for ScriptContainer {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
+#[allow(clippy::indexing_slicing)]
 mod tests {
     use std::sync::atomic::{AtomicBool, AtomicPtr};