Mark several classes as final for devirtualization performance benefits.
All checks were successful
continuous-integration/drone/push Build is passing

This commit is contained in:
2020-10-15 18:13:00 +02:00
parent f816975b63
commit fff926b617
20 changed files with 20 additions and 20 deletions

View File

@@ -6,7 +6,7 @@
#include "PkmnEventKind.hpp"
namespace PkmnLib::Battling {
class StatusChangeEvent : public CreatureLib::Battling::EventData {
class StatusChangeEvent final : public CreatureLib::Battling::EventData {
ArbUt::BorrowedPtr<Pokemon> _pokemon;
ArbUt::StringView _statusName;

View File

@@ -4,7 +4,7 @@
#include "PkmnEventKind.hpp"
namespace PkmnLib::Battling {
class WeatherChangeEvent : public CreatureLib::Battling::EventData {
class WeatherChangeEvent final : public CreatureLib::Battling::EventData {
ArbUt::StringView _weatherName;
public:

View File

@@ -9,7 +9,7 @@
#include "StatCalculator.hpp"
namespace PkmnLib::Battling {
class BattleLibrary : public CreatureLib::Battling::BattleLibrary {
class BattleLibrary final : public CreatureLib::Battling::BattleLibrary {
public:
BattleLibrary(Library::PokemonLibrary* staticLib, StatCalculator* statCalculator, DamageLibrary* damageLibrary,
PkmnLib::Battling::ExperienceLibrary* experienceLibrary,

View File

@@ -3,7 +3,7 @@
#include <CreatureLib/Battling/Library/DamageLibrary.hpp>
namespace PkmnLib::Battling {
class DamageLibrary : public CreatureLib::Battling::DamageLibrary {
class DamageLibrary final : public CreatureLib::Battling::DamageLibrary {
public:
uint32_t GetDamage(CreatureLib::Battling::ExecutingAttack* attack, CreatureLib::Battling::Creature* target,
uint8_t hitIndex,

View File

@@ -5,7 +5,7 @@
#include <CreatureLib/Defines.hpp>
namespace PkmnLib::Battling {
class ExperienceLibrary : public CreatureLib::Battling::ExperienceLibrary {
class ExperienceLibrary final : public CreatureLib::Battling::ExperienceLibrary {
public:
void HandleExperienceGain(
CreatureLib::Battling::Creature* faintedMon,

View File

@@ -6,7 +6,7 @@
#include "../Pokemon/LearnedMove.hpp"
namespace PkmnLib::Battling {
class MiscLibrary : public CreatureLib::Battling::MiscLibrary {
class MiscLibrary final : public CreatureLib::Battling::MiscLibrary {
std::unique_ptr<const PkmnLib::Library::MoveData> _struggleData = std::make_unique<PkmnLib::Library::MoveData>(
"struggle"_cnc, 0, PkmnLib::Library::MoveCategory::Physical, 50, 255, 10,
CreatureLib::Library::AttackTarget::Any, 0,

View File

@@ -7,7 +7,7 @@
namespace PkmnLib::Battling {
class Pokemon;
class StatCalculator : public CreatureLib::Battling::BattleStatCalculator {
class StatCalculator final : public CreatureLib::Battling::BattleStatCalculator {
protected:
virtual uint32_t CalculateHealthStat(const Pokemon* pkmn) const;
virtual uint32_t CalculateOtherStat(const Pokemon* pkmn, CreatureLib::Library::Statistic stat) const;

View File

@@ -4,7 +4,7 @@
#include <CreatureLib/Battling/Models/LearnedAttack.hpp>
#include "../../Library/Moves/MoveData.hpp"
namespace PkmnLib::Battling {
class LearnedMove : public CreatureLib::Battling::LearnedAttack {
class LearnedMove final : public CreatureLib::Battling::LearnedAttack {
public:
LearnedMove(const ArbUt::BorrowedPtr<const Library::MoveData>& move,
CreatureLib::Battling::AttackLearnMethod learnMethod)