Rework AngelScript effect names to be not based on script names, but on attributes instead.

tests/ScriptTests/ScriptTypeTests/Battle/PokemonTests.cpp

@@ -7,6 +7,7 @@
 static std::unordered_map<const char*, const char*> _scripts =
     std::unordered_map<const char*, const char*>{{"testScript1", R"(
 namespace Pokemon{
+[Pokemon effect=testScript1]
 class testScript1 {
     bool testSpecies(Pokemon@ p, const Species@ species){ return p.Species is species; }
     bool testForme(Pokemon@ p, const Forme@ forme){ return p.Forme is forme; }
@@ -55,6 +56,8 @@ static ScriptData GetScript(PkmnLib::Battling::BattleLibrary* mainLib, const Con
     auto lib = GetScriptResolver(mainLib);
     auto s = lib->LoadScript(ScriptCategory::Creature, "testScript1"_cnc);
     auto script = dynamic_cast<AngelScriptScript*>(s);
+    REQUIRE(script != nullptr);
+
     auto ctxPool = script->GetContextPool();
     auto ctx = ctxPool->RequestContext();
 

tests/ScriptTests/ScriptTypeTests/Library/FormesTests.cpp

@@ -6,6 +6,7 @@
 static std::unordered_map<const char*, const char*> _scripts =
     std::unordered_map<const char*, const char*>{{"testScript1", R"(
 namespace Pokemon{
+[Pokemon effect=testScript1]
 class testScript1 {
     bool testName(const Forme@ s, const constString &in name){ return s.Name == name; }
     bool testWeight(const Forme@ s, float weight){ return s.Weight == weight; }
@@ -45,6 +46,8 @@ static ScriptData GetScript(PkmnLib::Battling::BattleLibrary* mainLib, const Con
     auto lib = GetScriptResolver(mainLib);
     auto s = lib->LoadScript(ScriptCategory::Creature, "testScript1"_cnc);
     auto script = dynamic_cast<AngelScriptScript*>(s);
+    REQUIRE(script != nullptr);
+
     auto ctxPool = script->GetContextPool();
     auto ctx = ctxPool->RequestContext();
 

tests/ScriptTests/ScriptTypeTests/Library/ItemDataTests.cpp

@@ -6,6 +6,7 @@
 static std::unordered_map<const char*, const char*> _scripts =
     std::unordered_map<const char*, const char*>{{"testScript1", R"(
 namespace Pokemon{
+[Pokemon effect=testScript1]
 class testScript1 {
     bool testName(const Item@ i, const constString &in name){ return i.Name == name; }
     bool testCategory(const Item@ i, ItemCategory category){ return i.Category == category; }
@@ -41,6 +42,8 @@ static ScriptData GetScript(PkmnLib::Battling::BattleLibrary* mainLib, const Con
     auto lib = GetScriptResolver(mainLib);
     auto s = lib->LoadScript(ScriptCategory::Creature, "testScript1"_cnc);
     auto script = dynamic_cast<AngelScriptScript*>(s);
+    REQUIRE(script != nullptr);
+
     auto ctxPool = script->GetContextPool();
     auto ctx = ctxPool->RequestContext();
 

tests/ScriptTests/ScriptTypeTests/Library/MoveTests.cpp

@@ -6,6 +6,7 @@
 static std::unordered_map<const char*, const char*> _scripts =
     std::unordered_map<const char*, const char*>{{"testScript1", R"(
 namespace Pokemon{
+[Pokemon effect=testScript1]
 class testScript1 {
     bool testName(const MoveData@ s, const constString &in name){ return s.Name == name; }
     bool testType(const MoveData@ s, uint8 type){ return s.Type == type; }
@@ -45,6 +46,8 @@ static ScriptData GetScript(PkmnLib::Battling::BattleLibrary* mainLib, const Con
     auto lib = GetScriptResolver(mainLib);
     auto s = lib->LoadScript(ScriptCategory::Creature, "testScript1"_cnc);
     auto script = dynamic_cast<AngelScriptScript*>(s);
+    REQUIRE(script != nullptr);
+
     auto ctxPool = script->GetContextPool();
     auto ctx = ctxPool->RequestContext();
 

tests/ScriptTests/ScriptTypeTests/Library/SpeciesTests.cpp

@@ -6,6 +6,7 @@
 static std::unordered_map<const char*, const char*> _scripts =
     std::unordered_map<const char*, const char*>{{"testScript1", R"(
 namespace Pokemon{
+[Pokemon effect=testScript1]
 class testScript1 {
     bool testName(const Species@ s, const constString &in name){ return s.Name == name; }
     bool testId(const Species@ s, uint16 id){ return s.Id == id; }
@@ -43,6 +44,8 @@ static ScriptData GetScript(PkmnLib::Battling::BattleLibrary* mainLib, const Con
     auto lib = GetScriptResolver(mainLib);
     auto s = lib->LoadScript(ScriptCategory::Creature, "testScript1"_cnc);
     auto script = dynamic_cast<AngelScriptScript*>(s);
+    REQUIRE(script != nullptr);
+
     auto ctxPool = script->GetContextPool();
     auto ctx = ctxPool->RequestContext();
 

tests/ScriptTests/ScriptTypeTests/Library/StaticLibraryTests.cpp

@@ -6,6 +6,7 @@
 static std::unordered_map<const char*, const char*> _scripts =
     std::unordered_map<const char*, const char*>{{"testScript1", R"(
 namespace Pokemon{
+[Pokemon effect=testScript1]
 class testScript1 {
     bool testMaximumLevel(const StaticLibrary@ s, uint8 level){ return s.Settings.MaximalLevel == level; }
     bool testMaximumMoves(const StaticLibrary@ s, uint8 moveCount){ return s.Settings.MaximalMoves == moveCount; }
@@ -44,6 +45,8 @@ static ScriptData GetScript(PkmnLib::Battling::BattleLibrary* mainLib, const Con
     auto lib = GetScriptResolver(mainLib);
     auto s = lib->LoadScript(ScriptCategory::Creature, "testScript1"_cnc);
     auto script = dynamic_cast<AngelScriptScript*>(s);
+    REQUIRE(script != nullptr);
+
     auto ctxPool = script->GetContextPool();
     auto ctx = ctxPool->RequestContext();