Replace all raw string comparisons with StringKey, source generator that creates cache keys for all names for Gen7 plugin

2026-08-27 18:30:57 +02:00
parent 3a58f55bbf
commit 942be8eaeb
160 changed files with 1035 additions and 491 deletions
--- a/Plugins/PkmnLib.Plugin.Gen7/Scripts/Pokemon/SmackDownEffect.cs
+++ b/Plugins/PkmnLib.Plugin.Gen7/Scripts/Pokemon/SmackDownEffect.cs
@@ -9,7 +9,7 @@ public class SmackDownEffect : Script, IScriptChangeTypesForIncomingMove, IScrip
    {
        var typeLibrary = target.Library.StaticLibrary.Types;

-        if (executingMove.UseMove.MoveType.Name != "ground")
+        if (executingMove.UseMove.MoveType.Name != TypeNames.Ground)
            return;
        // Remove all types that are immune to ground moves
        types.RemoveAll(x => typeLibrary.GetSingleEffectiveness(executingMove.UseMove.MoveType, x) == 0);