Make ExecutingAttack have raw pointer array HitData, instead of a List. This is a very hot segment of code, and removing surrounding abstractions can give us a decent amount of performance.

src/Battling/Models/ExecutingAttack.hpp

@@ -38,7 +38,7 @@ namespace CreatureLib::Battling {
     private:
         ArbUt::List<Creature*> _targets;
         uint8_t _numberHits;
-        ArbUt::List<HitData> _hits;
+        HitData* _hits;
         Creature* _user;
         LearnedAttack* _attack;
         Script* _script;
@@ -46,15 +46,16 @@ namespace CreatureLib::Battling {
     public:
         ExecutingAttack(const ArbUt::List<Creature*>& targets, uint8_t numberHits, Creature* user,
                         LearnedAttack* attack, Script* script)
-            : _targets(targets.Count()), _numberHits(numberHits), _hits(targets.Count() * numberHits), _user(user),
-              _attack(attack), _script(script) {
+            : _targets(targets.Count()), _numberHits(numberHits), _hits(new HitData[targets.Count() * numberHits]),
+              _user(user), _attack(attack), _script(script) {
             AssertNotNull(user)
             AssertNotNull(attack)
             for (auto target : targets) {
                 _targets.Append(target);
-                _hits.Resize(numberHits);
             }
         }
+        ExecutingAttack(const ExecutingAttack&) = delete;
+        ExecutingAttack& operator=(const ExecutingAttack&) = delete;
 
         virtual ~ExecutingAttack() noexcept { delete _script; };
 
@@ -67,10 +68,11 @@ namespace CreatureLib::Battling {
             throw CreatureException("Invalid target requested.");
         }
 
-        std::vector<HitData>::iterator GetTargetIteratorBegin(Creature* creature) {
+        HitData* GetTargetIteratorBegin(Creature* creature) {
             for (size_t i = 0; i < _targets.Count(); i++) {
                 if (_targets[i] == creature) {
-                    return _hits.begin() + (i * _numberHits);
+                    auto v = _hits + (i * _numberHits * sizeof(HitData));
+                    return v;
                 }
             }
             throw CreatureException("Invalid target requested.");