Added lots of security using asserts.

src/Battling/Library/DamageLibrary.cpp

@@ -1,8 +1,11 @@
 #include "DamageLibrary.hpp"
+#include <Arbutils/Assert.hpp>
 #include "../ScriptHandling/ScriptMacros.hpp"
 
 using namespace CreatureLib::Battling;
 uint32_t DamageLibrary::GetDamage(ExecutingAttack* attack, Creature* target, uint8_t hitIndex) const {
+    AssertNotNull(attack)
+    AssertNotNull(target)
     auto levelMod = static_cast<float>(2 * attack->GetUser()->GetLevel());
     auto hit = attack->GetAttackDataForTarget(target)->GetHit(hitIndex);
     auto bp = hit->GetBasePower();
@@ -15,13 +18,18 @@ uint32_t DamageLibrary::GetDamage(ExecutingAttack* attack, Creature* target, uin
 }
 
 uint8_t DamageLibrary::GetBasePower(ExecutingAttack* attack, Creature* target, uint8_t hitIndex) const {
+    AssertNotNull(attack)
+    AssertNotNull(target)
     auto bp = attack->GetAttack()->GetAttack()->GetBasePower();
     HOOK(OverrideBasePower, attack, attack, target, hitIndex, &bp);
     return bp;
 }
 
 float DamageLibrary::GetStatModifier(ExecutingAttack* attack, Creature* target, uint8_t hitIndex) const {
+    AssertNotNull(attack)
+    AssertNotNull(target)
     auto user = attack->GetUser();
+    AssertNotNull(user)
     HOOK(ChangeDamageStatsUser, attack, attack, target, hitIndex, &user);
     auto hit = attack->GetAttackDataForTarget(target)->GetHit(hitIndex);
     Library::Statistic offensiveStat;
@@ -57,8 +65,11 @@ float DamageLibrary::GetStatModifier(ExecutingAttack* attack, Creature* target,
 }
 
 float DamageLibrary::GetDamageModifier(ExecutingAttack* attack, Creature* target, uint8_t hitIndex) const {
+    AssertNotNull(attack)
+    AssertNotNull(target)
     float mod = 1;
     auto hit = attack->GetAttackDataForTarget(target)->GetHit(hitIndex);
+    AssertNotNull(hit)
     mod *= hit->GetEffectiveness();
     HOOK(ModifyDamageModifier, attack, attack, target, hitIndex, &mod);
     return mod;