Deal with Creatures being deleted before a battle they're part of.

Signed-off-by: Deukhoofd <Deukhoofd@gmail.com>

src/Battling/Models/BattleSide.cpp

@@ -54,7 +54,7 @@ void BattleSide::SetCreature(ArbUt::OptionalBorrowedPtr<Creature> creature, uint
     if (old.HasValue()) {
         old.GetValue()->SetOnBattleField(false);
     }
-    _creatures[index] = creature.GetValue();
+    _creatures[index] = creature;
     if (!creature.HasValue()) {
         return;
     }

src/Battling/Models/BattleSide.hpp

@@ -40,6 +40,7 @@ namespace CreatureLib::Battling {
         void SetChoice(BaseTurnChoice* choice);
         void ResetChoices() noexcept;
 
+        void ForceClearCreature(uint8_t index) { _creatures[index] = {}; }
         void SetCreature(ArbUt::OptionalBorrowedPtr<Creature> creature, uint8_t index);
 
         const ArbUt::OptionalBorrowedPtr<Creature>& GetCreature(uint8_t index) const;

src/Battling/Models/Creature.cpp

@@ -392,3 +392,9 @@ void CreatureLib::Battling::Creature::ClearStatus() {
         _battleData.Battle.GetValue()->TriggerEventListener<StatusChangeEvent>(this, ""_cnc);
     }
 }
+
+Battling::Creature::~Creature() {
+    if (_battleData.OnBattleField && _battleData.Side.HasValue()) {
+        _battleData.Side.GetValue()->ForceClearCreature(_battleData.Index.GetCreatureIndex());
+    }
+}

src/Battling/Models/Creature.hpp

@@ -75,7 +75,7 @@ namespace CreatureLib::Battling {
                  const Library::TalentIndex& talent, const std::vector<LearnedAttack*>& attacks,
                  bool allowedExperienceGain = true);
 
-        virtual ~Creature() = default;
+        virtual ~Creature();
 
         virtual void Initialize() {
             RecalculateFlatStats();

tests/BattleTests/CreatureTests.cpp

@@ -1,5 +1,6 @@
 #ifdef TESTS_BUILD
 #include "../../extern/doctest.hpp"
+#include "../../src/Battling/Models/Battle.hpp"
 #include "../../src/Battling/Models/CreateCreature.hpp"
 #include "../TestLibrary/TestLibrary.hpp"
 
@@ -54,4 +55,16 @@ TEST_CASE("Override Creature talent") {
     delete creature;
 }
 
+TEST_CASE("Creature can be deleted before battle is deleted") {
+    // This should not happen during normal battle executions, but can happen for certain GC solutions. We should not
+    // segfault in this case, but deal with it properly.
+    auto library = TestLibrary::Get();
+    auto creature = CreateCreature(library, "testSpecies1"_cnc, 1).Create();
+    auto battle = new Battle(library, {});
+    auto side = battle->GetSides()[0];
+    side->SetCreature(creature, 0);
+    delete creature;
+    delete battle;
+}
+
 #endif