Initialize CreateCreature with ConstString instead of std::string.

tests/Integration/BattleIntegrations.cpp

@@ -13,8 +13,9 @@ using namespace Battling;
 
 TEST_CASE("Create Party", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty = BattleParty(&party1, {CreatureIndex(0, 0)});
     REQUIRE(battleParty.GetParty()->GetAtIndex(0) == c1);
@@ -22,12 +23,14 @@ TEST_CASE("Create Party", "[Integrations]") {
 
 TEST_CASE("Create Battle", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
-    auto c2 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c2 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party2{c2};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -36,12 +39,14 @@ TEST_CASE("Create Battle", "[Integrations]") {
 
 TEST_CASE("Use damaging move", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
-    auto c2 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c2 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party2{c2};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -58,12 +63,14 @@ TEST_CASE("Use damaging move", "[Integrations]") {
 
 TEST_CASE("Finish battle when all battle of one side have fainted", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
-    auto c2 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c2 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party2{c2};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -93,12 +100,13 @@ TEST_CASE("Finish battle when all battle of one side have fainted", "[Integratio
 
 TEST_CASE("When creature is dealt enough damage, faint it and mark battle as ended", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 100).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 100)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
     auto c2 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party2{c2};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -122,14 +130,15 @@ TEST_CASE("When creature is dealt enough damage, faint it and mark battle as end
 
 TEST_CASE("When another creature is available on faint, make sure the battle hasn't ended", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 100).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 100)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
     auto c2 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     auto c3 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party2{c2, c3};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -160,14 +169,15 @@ TEST_CASE("When another creature is available on faint, make sure the battle has
 
 TEST_CASE("Switch Creature in", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 100).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 100)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     auto c2 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party1{c1, c2};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
     auto c3 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party2{c3};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -186,14 +196,17 @@ TEST_CASE("Switch Creature in", "[Integrations]") {
 
 TEST_CASE("Switch Creature in, but have attack aimed at it. Attack should hit new creature", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
-    auto c2 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
+    auto c2 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1, c2};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
-    auto c3 =
-        CreateCreature(library, "testSpecies1", 50).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c3 = CreateCreature(library, "testSpecies1"_cnc, 50)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party2{c3};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -211,14 +224,15 @@ TEST_CASE("Switch Creature in, but have attack aimed at it. Attack should hit ne
 
 TEST_CASE("Switch Creature in, mark as seen opponent for opponent", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 100).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 100)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     auto c2 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party1{c1, c2};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
     auto c3 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party2{c3};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});
 
@@ -250,12 +264,13 @@ TEST_CASE("Switch Creature in, mark as seen opponent for opponent", "[Integratio
 
 TEST_CASE("Flee Battle", "[Integrations]") {
     auto library = TestLibrary::Get();
-    auto c1 =
-        CreateCreature(library, "testSpecies1", 100).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+    auto c1 = CreateCreature(library, "testSpecies1"_cnc, 100)
+                  .WithAttack("standard"_cnc, AttackLearnMethod::Unknown)
+                  ->Create();
     CreatureParty party1{c1};
     auto battleParty1 = new BattleParty(&party1, {CreatureIndex(0, 0)});
     auto c2 =
-        CreateCreature(library, "testSpecies1", 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
+        CreateCreature(library, "testSpecies1"_cnc, 1).WithAttack("standard"_cnc, AttackLearnMethod::Unknown)->Create();
     CreatureParty party2{c2};
     auto battleParty2 = new BattleParty(&party2, {CreatureIndex(1, 0)});