Use std::optional for BaseLibrary TryGet.

Signed-off-by: Deukhoofd <Deukhoofd@gmail.com>
2020-12-12 12:42:28 +01:00
parent 5c39694f19
commit 185ec40ba5
4 changed files with 28 additions and 17 deletions
--- a/src/Library/BaseLibrary.hpp
+++ b/src/Library/BaseLibrary.hpp
@@ -39,12 +39,11 @@ namespace CreatureLib::Library {
        bool TryGet(const ArbUt::BasicStringView& name, ArbUt::BorrowedPtr<const T>& out) const noexcept {
            return TryGet(name.GetHash(), out);
        }
-        bool TryGet(uint32_t hashedKey, ArbUt::BorrowedPtr<const T>& out) const noexcept {
+        std::optional<ArbUt::BorrowedPtr<const T>> TryGet(uint32_t hashedKey) const noexcept {
            auto find = _values.GetStdMap().find(hashedKey);
            if (find == _values.GetStdMap().end())
-                return false;
-            out = std::get<1>(*find);
-            return true;
+                return {};
+            return std::get<1>(*find);
        }

        [[nodiscard]] inline ArbUt::BorrowedPtr<const T> Get(const ArbUt::BasicStringView& name) const {