Deukhoofd
/
Arbutils
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add virtual destructor to BasicStringView.
continuous-integration/drone/push Build is failing Details

This commit is contained in:
Deukhoofd 2020-06-26 16:17:19 +02:00
parent 088f66c385
commit 94fec63c1b
Signed by: Deukhoofd
GPG Key ID: ADF2E9256009EDCE
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/String/BasicStringView.hpp
View File

@ -11,6 +11,8 @@ namespace ArbUt {
constexpr BasicStringView(size_t length, uint32_t hash) : _length(length), _hash(hash) {} constexpr BasicStringView(size_t length, uint32_t hash) : _length(length), _hash(hash) {}
public: public:
virtual ~BasicStringView() = default;
[[nodiscard]] inline constexpr size_t Length() const noexcept { return _length; } [[nodiscard]] inline constexpr size_t Length() const noexcept { return _length; }
[[nodiscard]] inline constexpr uint32_t GetHash() const noexcept { return _hash; } [[nodiscard]] inline constexpr uint32_t GetHash() const noexcept { return _hash; }
[[nodiscard]] inline constexpr std::size_t operator()(BasicStringView const& s) const noexcept { return _hash; } [[nodiscard]] inline constexpr std::size_t operator()(BasicStringView const& s) const noexcept { return _hash; }

2
src/String/StringView.hpp
View File

@ -77,7 +77,7 @@ namespace ArbUt {
return *this; return *this;
} }
~StringView() noexcept { _str->RemoveReference(); } ~StringView() noexcept override { _str->RemoveReference(); }
[[nodiscard]] inline constexpr const char* c_str() const noexcept override { return _str->GetValue().data(); } [[nodiscard]] inline constexpr const char* c_str() const noexcept override { return _str->GetValue().data(); }
[[nodiscard]] inline std::string_view std_str() const noexcept override { return _str->GetValue(); } [[nodiscard]] inline std::string_view std_str() const noexcept override { return _str->GetValue(); }