Replace all raw string comparisons with StringKey, source generator that creates cache keys for all names for Gen7 plugin

2026-08-27 18:30:57 +02:00
parent 3a58f55bbf
commit 942be8eaeb
160 changed files with 1035 additions and 491 deletions
--- a/Plugins/PkmnLib.Plugin.Gen7/Scripts/Battle/IonDelugeEffect.cs
+++ b/Plugins/PkmnLib.Plugin.Gen7/Scripts/Battle/IonDelugeEffect.cs
@@ -6,8 +6,8 @@ public class IonDelugeEffect : Script, IScriptChangeMoveType, IScriptOnEndTurn
    /// <inheritdoc />
    public void ChangeMoveType(IExecutingMove move, IPokemon target, byte hit, ref TypeIdentifier? moveType)
    {
-        if (moveType?.Name == "normal" &&
-            target.Library.StaticLibrary.Types.TryGetTypeIdentifier("electric", out var electricType))
+        if (moveType?.Name == TypeNames.Normal &&
+            target.Library.StaticLibrary.Types.TryGetTypeIdentifier(TypeNames.Electric, out var electricType))
        {
            moveType = electricType;
        }