Replace all raw string comparisons with StringKey, source generator that creates cache keys for all names for Gen7 plugin

2026-08-27 18:30:57 +02:00
parent 3a58f55bbf
commit 942be8eaeb
160 changed files with 1035 additions and 491 deletions
--- a/Plugins/PkmnLib.Plugin.Gen7/Scripts/Abilities/RKSSystem.cs
+++ b/Plugins/PkmnLib.Plugin.Gen7/Scripts/Abilities/RKSSystem.cs
@@ -11,9 +11,9 @@ public class RksSystem : Script, IScriptOnAfterHeldItemChange
    /// <inheritdoc />
    public void OnAfterHeldItemChange(IPokemon pokemon, IItem? previous, IItem? item)
    {
-        if (pokemon.Species.Name != "silvally")
+        if (pokemon.Species.Name != SpeciesNames.Silvally)
            return;
-        if (item is null && pokemon.Form.Name != "default")
+        if (item is null && pokemon.Form.Name != FormNames.Default)
        {
            pokemon.ChangeForm(pokemon.Species.GetDefaultForm());
        }