Deukhoofd/PkmnLib.NET
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move all battle state from IPokemon to an ephemeral IBattlePokemon wrapper

Browse Source
This commit is contained in:
Deukhoofd
2026-08-28 15:20:26 +02:00
parent 942be8eaeb
commit 8a2733a0a9
859 changed files with 4408 additions and 5331 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
Plugins/PkmnLib.Plugin.Gen7.Tests/Scripts/Moves/MagnitudeTests.cs
View File

@@ -13,8 +13,8 @@ namespace PkmnLib.Plugin.Gen7.Tests.Scripts.Moves;
/// </summary>
public class MagnitudeTests
{
private static (Magnitude script, IExecutingMove move, IPokemon target, IPokemon user, EventHook eventHook)
CreateTestSetup(int randomValue)
private static (Magnitude script, IExecutingMove move, IBattlePokemon target, IBattlePokemon user, EventHook
eventHook) CreateTestSetup(int randomValue)
{
var script = new Magnitude();
@@ -26,14 +26,11 @@ public class MagnitudeTests
battle.Random.Returns(random);
battle.EventHook.Returns(eventHook);
var battleData = Substitute.For<IPokemonBattleData>();
battleData.Battle.Returns(battle);
var user = Substitute.For<IPokemon>();
user.BattleData.Returns(battleData);
var user = Substitute.For<IBattlePokemon>();
var move = Substitute.For<IExecutingMove>();
user.Battle.Returns(battle);
move.User.Returns(user);
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
return (script, move, target, user, eventHook);
}
@@ -59,7 +56,7 @@ public class MagnitudeTests
// magnitude 9 bracket start
// magnitude 9 bracket end
// magnitude 10 bracket start
// magnitude 10 bracket end
// magnitude 10 bracket end
public async Task ChangeBasePower_RandomRoll_MapsToExpectedBasePower(int randomValue, int expectedPower)
{
// Arrange
@@ -154,29 +151,7 @@ public class MagnitudeTests
// Assert
await Assert.That(capturedEvent).IsNotNull();
await Assert.That((IPokemon)capturedEvent!.Parameters!["user"]).IsEqualTo(user);
await Assert.That((IPokemon)capturedEvent.Parameters!["target"]).IsEqualTo(target);
}
/// <summary>
/// Technical test: when the user has no <see cref="IPokemon.BattleData"/> (it is not in a battle),
/// no random roll can be made and the base power is left unchanged.
/// </summary>
[Test]
public async Task ChangeBasePower_NullBattleData_BasePowerUnchanged()
{
// Arrange
var script = new Magnitude();
var user = Substitute.For<IPokemon>();
user.BattleData.Returns((IPokemonBattleData?)null);
var move = Substitute.For<IExecutingMove>();
move.User.Returns(user);
ushort basePower = 1;
// Act
script.ChangeBasePower(move, Substitute.For<IPokemon>(), 0, ref basePower);
// Assert
await Assert.That(basePower).IsEqualTo((ushort)1);
await Assert.That((IBattlePokemon)capturedEvent!.Parameters!["user"]).IsEqualTo(user);
await Assert.That((IBattlePokemon)capturedEvent.Parameters!["target"]).IsEqualTo(target);
}
}