Move all battle state from IPokemon to an ephemeral IBattlePokemon wrapper

This commit is contained in:
2026-08-28 15:20:26 +02:00
parent 942be8eaeb
commit 8a2733a0a9
859 changed files with 4408 additions and 5331 deletions

View File

@@ -16,18 +16,18 @@ namespace PkmnLib.Plugin.Gen7.Tests.Scripts.Moves;
/// </summary>
public class LockOnTests
{
private static (LockOn script, IExecutingMove move, IPokemon user, IPokemon target, ScriptSet targetVolatile)
CreateTestSetup()
private static (LockOn script, IExecutingMove move, IBattlePokemon user, IBattlePokemon target, ScriptSet
targetVolatile) CreateTestSetup()
{
var script = new LockOn();
var move = Substitute.For<IExecutingMove>();
var user = Substitute.For<IPokemon>();
var user = Substitute.For<IBattlePokemon>();
move.User.Returns(user);
// Use a real script set so the volatile script added by Lock-On can be inspected afterwards, and so
// that Script.RemoveSelf calls can be observed through IScriptSet.Contains.
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
var targetVolatile = new ScriptSet(target);
target.Volatile.Returns(targetVolatile);
target.GetScripts().Returns(_ => new ScriptIterator(new List<IEnumerable<ScriptContainer>>()));
@@ -62,14 +62,14 @@ public class LockOnTests
public async Task ChangeIncomingAccuracy_AttackByLockOnUser_AccuracyGuaranteed()
{
// Arrange
var placer = Substitute.For<IPokemon>();
var placer = Substitute.For<IBattlePokemon>();
var effect = new LockOnEffect(placer);
var attack = Substitute.For<IExecutingMove>();
attack.User.Returns(placer);
var accuracy = 90;
// Act
effect.ChangeIncomingAccuracy(attack, Substitute.For<IPokemon>(), 0, ref accuracy);
effect.ChangeIncomingAccuracy(attack, Substitute.For<IBattlePokemon>(), 0, ref accuracy);
// Assert
await Assert.That(accuracy).IsGreaterThanOrEqualTo(255);
@@ -83,14 +83,14 @@ public class LockOnTests
public async Task ChangeIncomingAccuracy_AttackByOtherPokemon_AccuracyUnchanged()
{
// Arrange
var placer = Substitute.For<IPokemon>();
var placer = Substitute.For<IBattlePokemon>();
var effect = new LockOnEffect(placer);
var attack = Substitute.For<IExecutingMove>();
attack.User.Returns(Substitute.For<IPokemon>());
attack.User.Returns(Substitute.For<IBattlePokemon>());
var accuracy = 90;
// Act
effect.ChangeIncomingAccuracy(attack, Substitute.For<IPokemon>(), 0, ref accuracy);
effect.ChangeIncomingAccuracy(attack, Substitute.For<IBattlePokemon>(), 0, ref accuracy);
// Assert
await Assert.That(accuracy).IsEqualTo(90);