Move all battle state from IPokemon to an ephemeral IBattlePokemon wrapper
This commit is contained in:
@@ -18,8 +18,8 @@ public class DoomDesireTests
|
||||
/// Creates a fully mocked test setup where the target is at the given position on a side whose
|
||||
/// volatile scripts are a real <see cref="ScriptSet"/>.
|
||||
/// </summary>
|
||||
private static (DoomDesire script, IExecutingMove move, IPokemon target, IBattleSide side, ScriptSet sideScripts,
|
||||
IHitData hitData) CreateTestSetup(byte position = 0, uint damage = 100)
|
||||
private static (DoomDesire script, IExecutingMove move, IBattlePokemon target, IBattleSide side, ScriptSet
|
||||
sideScripts, IHitData hitData) CreateTestSetup(byte position = 0, uint damage = 100)
|
||||
{
|
||||
var script = new DoomDesire();
|
||||
var move = Substitute.For<IExecutingMove>();
|
||||
@@ -31,13 +31,11 @@ public class DoomDesireTests
|
||||
var battle = Substitute.For<IBattle>();
|
||||
battle.Sides.Returns(new[] { side });
|
||||
|
||||
var target = Substitute.For<IPokemon>();
|
||||
var battleData = Substitute.For<IPokemonBattleData>();
|
||||
battleData.Battle.Returns(battle);
|
||||
battleData.SideIndex.Returns((byte)0);
|
||||
battleData.Position.Returns(position);
|
||||
target.BattleData.Returns(battleData);
|
||||
side.Pokemon.Returns(new IPokemon?[] { target });
|
||||
var target = Substitute.For<IBattlePokemon>();
|
||||
target.Battle.Returns(battle);
|
||||
target.SideIndex.Returns((byte)0);
|
||||
target.Position.Returns(position);
|
||||
side.Pokemon.Returns(new IBattlePokemon?[] { target });
|
||||
|
||||
var hitData = Substitute.For<IHitData>();
|
||||
hitData.Damage.Returns(damage);
|
||||
@@ -175,25 +173,4 @@ public class DoomDesireTests
|
||||
// Assert
|
||||
await Assert.That(sideScripts.Contains(ScriptUtils.ResolveName<DoomDesireEffect>())).IsFalse();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Technical test: without battle data on the target (outside of battle) the script does nothing and
|
||||
/// does not throw.
|
||||
/// </summary>
|
||||
[Test]
|
||||
public async Task BlockOutgoingHit_TargetHasNoBattleData_DoesNotBlock()
|
||||
{
|
||||
// Arrange
|
||||
var script = new DoomDesire();
|
||||
var move = Substitute.For<IExecutingMove>();
|
||||
var target = Substitute.For<IPokemon>();
|
||||
target.BattleData.Returns((IPokemonBattleData?)null);
|
||||
var block = false;
|
||||
|
||||
// Act
|
||||
script.BlockOutgoingHit(move, target, 0, ref block);
|
||||
|
||||
// Assert
|
||||
await Assert.That(block).IsFalse();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user