Deukhoofd/PkmnLib.NET
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move all battle state from IPokemon to an ephemeral IBattlePokemon wrapper

Browse Source
This commit is contained in:
Deukhoofd
2026-08-28 15:20:26 +02:00
parent 942be8eaeb
commit 8a2733a0a9
859 changed files with 4408 additions and 5331 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
Plugins/PkmnLib.Plugin.Gen7.Tests/Scripts/MoveVolatile/FireWaterPledgeMoveTests.cs
View File

@@ -20,7 +20,7 @@ public class FireWaterPledgeMoveTests
/// Creates a fully mocked test setup. The user's battle side gets a real <see cref="ScriptSet"/> as its
/// volatile script set, so the rainbow created by the combined move can be inspected and driven.
/// </summary>
private static (FireWaterPledgeMove script, IExecutingMove move, IPokemon user, IBattleSide side, IScriptSet
private static (FireWaterPledgeMove script, IExecutingMove move, IBattlePokemon user, IBattleSide side, IScriptSet
sideVolatile) CreateTestSetup()
{
var script = new FireWaterPledgeMove();
@@ -31,11 +31,9 @@ public class FireWaterPledgeMoveTests
var sideVolatile = new ScriptSet(side);
side.VolatileScripts.Returns(sideVolatile);
var battleData = Substitute.For<IPokemonBattleData>();
battleData.BattleSide.Returns(side);
var user = Substitute.For<IPokemon>();
user.BattleData.Returns(battleData);
var user = Substitute.For<IBattlePokemon>();
move.User.Returns(user);
user.BattleSide.Returns(side);
return (script, move, user, side, sideVolatile);
}
@@ -67,7 +65,7 @@ public class FireWaterPledgeMoveTests
{
// Arrange
var (script, move, _, _, _) = CreateTestSetup();
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
ushort basePower = 80;
// Act
@@ -86,7 +84,7 @@ public class FireWaterPledgeMoveTests
{
// Arrange
var (script, move, _, _, sideVolatile) = CreateTestSetup();
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
// Act
script.OnSecondaryEffect(move, target, 0);
@@ -95,25 +93,6 @@ public class FireWaterPledgeMoveTests
await Assert.That(sideVolatile.Get<RainbowEffect>()).IsNotNull();
}
/// <summary>
/// Technical test: if the user has no <see cref="IPokemon.BattleData"/>, no rainbow is created and the
/// script does not throw.
/// </summary>
[Test]
public async Task OnSecondaryEffect_UserHasNoBattleData_DoesNothing()
{
// Arrange
var (script, move, user, _, sideVolatile) = CreateTestSetup();
user.BattleData.Returns((IPokemonBattleData?)null);
var target = Substitute.For<IPokemon>();
// Act
script.OnSecondaryEffect(move, target, 0);
// Assert
await Assert.That(sideVolatile.Count).IsEqualTo(0);
}
/// <summary>
/// Bulbapedia: "The rainbow doubles the probability of additional effects taking place for moves used
/// by that side of the field".
@@ -123,7 +102,7 @@ public class FireWaterPledgeMoveTests
{
// Arrange
var (script, move, _, _, sideVolatile) = CreateTestSetup();
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
script.OnSecondaryEffect(move, target, 0);
var rainbow = sideVolatile.Get<RainbowEffect>()!;
@@ -143,7 +122,7 @@ public class FireWaterPledgeMoveTests
{
// Arrange
var (script, move, _, side, sideVolatile) = CreateTestSetup();
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
script.OnSecondaryEffect(move, target, 0);
var rainbow = sideVolatile.Get<RainbowEffect>()!;
var battle = Substitute.For<IBattle>();
@@ -165,7 +144,7 @@ public class FireWaterPledgeMoveTests
{
// Arrange
var (script, move, _, side, sideVolatile) = CreateTestSetup();
var target = Substitute.For<IPokemon>();
var target = Substitute.For<IBattlePokemon>();
script.OnSecondaryEffect(move, target, 0);
var rainbow = sideVolatile.Get<RainbowEffect>()!;
var battle = Substitute.For<IBattle>();