Deukhoofd
/
Arbutils
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Better handling of out of bound enum values in ToString.
continuous-integration/drone/push Build is failing Details

This commit is contained in:
Deukhoofd 2020-04-10 19:51:35 +02:00
parent 60802341b0
commit 9244249a64
Signed by: Deukhoofd
GPG Key ID: ADF2E9256009EDCE
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Enum.hpp
View File

@ -61,7 +61,11 @@
public: \ public: \
constexpr static const char* ToString(name value) { \ constexpr static const char* ToString(name value) { \
switch (value) { MACRO_UTILS_FOR_EACH(ENUM_CASE, name, values) } \ switch (value) { MACRO_UTILS_FOR_EACH(ENUM_CASE, name, values) } \
throw std::logic_error("Not reachable"); \ auto v = static_cast<int>(value); \
auto size = (int)((ceil(log10(v)) + 1) * sizeof(char)); \
char* snum = new char[size]; \
sprintf(snum, "%d", v); \
return snum; \
} \ } \
constexpr static name Parse(const char* input, bool caseInsensitive = false) { \ constexpr static name Parse(const char* input, bool caseInsensitive = false) { \
if (caseInsensitive) \ if (caseInsensitive) \

1
tests/EnumTests.cpp
View File

@ -56,6 +56,7 @@ TEST_CASE("Enum To String", "[Utilities]") {
CHECK(strcmp(TestEnumHelper::ToString(TestEnum::Val1), "Val1") == 0); CHECK(strcmp(TestEnumHelper::ToString(TestEnum::Val1), "Val1") == 0);
CHECK(strcmp(TestEnumHelper::ToString(TestEnum::Val2), "Val2") == 0); CHECK(strcmp(TestEnumHelper::ToString(TestEnum::Val2), "Val2") == 0);
CHECK(strcmp(TestEnumHelper::ToString(TestEnum::Val3), "Val3") == 0); CHECK(strcmp(TestEnumHelper::ToString(TestEnum::Val3), "Val3") == 0);
CHECK(strcmp(TestEnumHelper::ToString((TestEnum)100), "100") == 0);
} }
TEST_CASE("Enum Get Values", "[Utilities]") { TEST_CASE("Enum Get Values", "[Utilities]") {