From 907e4443898151d0c69eea28610e01a2e3e30ffa Mon Sep 17 00:00:00 2001 From: Deukhoofd Date: Mon, 24 Jun 2019 15:09:00 +0200 Subject: [PATCH] More valgrind fixes Signed-off-by: Deukhoofd --- src/Evaluator/EvalValues/EvalValue.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Evaluator/EvalValues/EvalValue.cpp b/src/Evaluator/EvalValues/EvalValue.cpp index ce8390a..824c22e 100644 --- a/src/Evaluator/EvalValues/EvalValue.cpp +++ b/src/Evaluator/EvalValues/EvalValue.cpp @@ -33,7 +33,6 @@ namespace Porygon::Evaluation { for (int i = 0; i < result.size(); i++){ dst[i] = result[i]; } - dst[result.size() + 1] = '\0'; return 0; } @@ -60,7 +59,6 @@ namespace Porygon::Evaluation { #include #include "../src/Script.hpp" - TEST_CASE( "Evaluate String", "[integration]" ) { auto sc = new u16string(u"\"foo bar\""); auto script = Porygon::Script::Create(*sc); @@ -68,10 +66,11 @@ TEST_CASE( "Evaluate String", "[integration]" ) { script->Evaluate(); auto lastValue = script->GetLastValue(); size_t size = GetEvalValueStringLength(lastValue); - char16_t dst[size + 1]; + auto dst = new char16_t[size + 1]{'\0'}; EvaluateEvalValueString(lastValue, dst); auto s = u16string(dst); REQUIRE(s == u"foo bar"); + delete[] dst; delete script; delete sc; }