Rework evaluation to use shared pointers, fix bugs
This commit is contained in:
@@ -5,68 +5,58 @@
|
||||
#include "EvalValues/NumericEvalValue.hpp"
|
||||
#include "EvalValues/StringEvalValue.hpp"
|
||||
|
||||
NumericEvalValue* Evaluator::EvaluateIntegerBinary(BoundBinaryExpression *expression) {
|
||||
NumericEvalValue* leftValue = this -> EvaluateIntegerExpression(expression->GetLeft());
|
||||
NumericEvalValue* rightValue = this -> EvaluateIntegerExpression(expression->GetRight());
|
||||
shared_ptr<NumericEvalValue> Evaluator::EvaluateIntegerBinary(BoundBinaryExpression *expression) {
|
||||
auto leftValue = this -> EvaluateIntegerExpression(expression->GetLeft());
|
||||
auto rightValue = this -> EvaluateIntegerExpression(expression->GetRight());
|
||||
|
||||
NumericEvalValue* result;
|
||||
switch (expression->GetOperation()){
|
||||
case BoundBinaryOperation ::Addition:
|
||||
result = leftValue -> operator+ (rightValue);
|
||||
result = leftValue.get() -> operator+ (rightValue.get());
|
||||
break;
|
||||
case BoundBinaryOperation::Subtraction:
|
||||
result = leftValue -> operator- (rightValue);
|
||||
result = leftValue.get() -> operator- (rightValue.get());
|
||||
break;
|
||||
case BoundBinaryOperation::Multiplication:
|
||||
result = leftValue -> operator* (rightValue);
|
||||
result = leftValue.get() -> operator* (rightValue.get());
|
||||
break;
|
||||
case BoundBinaryOperation::Division:
|
||||
result = leftValue -> operator/ (rightValue);
|
||||
result = leftValue.get() -> operator/ (rightValue.get());
|
||||
break;
|
||||
default:
|
||||
delete leftValue;
|
||||
delete rightValue;
|
||||
throw EvaluationException("Can't evaluate operation to numeric");
|
||||
}
|
||||
delete leftValue;
|
||||
delete rightValue;
|
||||
return result;
|
||||
return shared_ptr<NumericEvalValue>(result);
|
||||
}
|
||||
|
||||
BooleanEvalValue* Evaluator::EvaluateBooleanBinary(BoundBinaryExpression* expression){
|
||||
shared_ptr<BooleanEvalValue> Evaluator::EvaluateBooleanBinary(BoundBinaryExpression* expression){
|
||||
switch (expression->GetOperation()){
|
||||
case BoundBinaryOperation::Equality:
|
||||
{
|
||||
EvalValue* leftValue = this -> EvaluateExpression(expression->GetLeft());
|
||||
EvalValue* rightValue = this -> EvaluateExpression(expression->GetRight());
|
||||
bool equals = leftValue->operator==(rightValue);
|
||||
delete leftValue;
|
||||
delete rightValue;
|
||||
return new BooleanEvalValue(equals);
|
||||
auto leftValue = this -> EvaluateExpression(expression->GetLeft());
|
||||
auto rightValue = this -> EvaluateExpression(expression->GetRight());
|
||||
bool equals = leftValue.get()->operator==(rightValue.get());
|
||||
return make_shared<BooleanEvalValue>(equals);
|
||||
}
|
||||
case BoundBinaryOperation::Inequality:
|
||||
{
|
||||
EvalValue* leftValue = this -> EvaluateExpression(expression->GetLeft());
|
||||
EvalValue* rightValue = this -> EvaluateExpression(expression->GetRight());
|
||||
bool equals = leftValue->operator!=(rightValue);
|
||||
delete leftValue;
|
||||
delete rightValue;
|
||||
return new BooleanEvalValue(equals);
|
||||
auto leftValue = this -> EvaluateExpression(expression->GetLeft());
|
||||
auto rightValue = this -> EvaluateExpression(expression->GetRight());
|
||||
bool equals = leftValue.get()->operator!=(rightValue.get());
|
||||
return make_shared<BooleanEvalValue>(equals);
|
||||
}
|
||||
case BoundBinaryOperation::LogicalAnd:
|
||||
{
|
||||
BooleanEvalValue* leftValue = this -> EvaluateBoolExpression(expression->GetLeft());
|
||||
auto leftValue = this -> EvaluateBoolExpression(expression->GetLeft());
|
||||
if (!leftValue->EvaluateBool()) return leftValue;
|
||||
delete leftValue;
|
||||
BooleanEvalValue* rightValue = this -> EvaluateBoolExpression(expression->GetRight());
|
||||
auto rightValue = this -> EvaluateBoolExpression(expression->GetRight());
|
||||
return rightValue;
|
||||
}
|
||||
case BoundBinaryOperation::LogicalOr:
|
||||
{
|
||||
BooleanEvalValue* leftValue = this -> EvaluateBoolExpression(expression->GetLeft());
|
||||
auto leftValue = this -> EvaluateBoolExpression(expression->GetLeft());
|
||||
if (leftValue->EvaluateBool()) return leftValue;
|
||||
delete leftValue;
|
||||
BooleanEvalValue* rightValue = this -> EvaluateBoolExpression(expression->GetRight());
|
||||
auto rightValue = this -> EvaluateBoolExpression(expression->GetRight());
|
||||
return rightValue;
|
||||
}
|
||||
default:
|
||||
@@ -74,15 +64,13 @@ BooleanEvalValue* Evaluator::EvaluateBooleanBinary(BoundBinaryExpression* expres
|
||||
}
|
||||
}
|
||||
|
||||
StringEvalValue* Evaluator::EvaluateStringBinary(BoundBinaryExpression* expression){
|
||||
shared_ptr<StringEvalValue> Evaluator::EvaluateStringBinary(BoundBinaryExpression* expression){
|
||||
if (expression->GetOperation() != BoundBinaryOperation::Concatenation)
|
||||
throw;
|
||||
std::ostringstream strs;
|
||||
auto left = this -> EvaluateStringExpression(expression->GetLeft());
|
||||
strs << left->EvaluateString();
|
||||
delete left;
|
||||
auto right = this -> EvaluateExpression(expression->GetRight());
|
||||
strs << right->EvaluateString();
|
||||
delete right;
|
||||
return new StringEvalValue(strs.str());
|
||||
return make_shared<StringEvalValue>(strs.str());
|
||||
}
|
||||
Reference in New Issue
Block a user