From a92b9c096ae684c4574506cdfc8c7ed3e1a4fe80 Mon Sep 17 00:00:00 2001 From: Deukhoofd Date: Sun, 29 Oct 2023 15:18:37 +0100 Subject: [PATCH] Fixes dumb perf overhead for Vec getting extensions --- src/utils/vec_ext.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/utils/vec_ext.rs b/src/utils/vec_ext.rs index fc74ee3..a37a836 100644 --- a/src/utils/vec_ext.rs +++ b/src/utils/vec_ext.rs @@ -13,12 +13,12 @@ impl VecExt for [T] { fn get_mut_res(&mut self, index: usize) -> Result<&mut T> { let len = self.len(); self.get_mut(index) - .ok_or(PkmnError::IndexOutOfBounds { index, len }.into()) + .ok_or_else(|| PkmnError::IndexOutOfBounds { index, len }.into()) } fn get_res(&self, index: usize) -> Result<&T> { self.get(index) - .ok_or(PkmnError::IndexOutOfBounds { index, len: self.len() }.into()) + .ok_or_else(|| PkmnError::IndexOutOfBounds { index, len: self.len() }.into()) } } @@ -26,11 +26,11 @@ impl VecExt for Vec { fn get_mut_res(&mut self, index: usize) -> Result<&mut T> { let len = self.len(); self.get_mut(index) - .ok_or(PkmnError::IndexOutOfBounds { index, len }.into()) + .ok_or_else(|| PkmnError::IndexOutOfBounds { index, len }.into()) } fn get_res(&self, index: usize) -> Result<&T> { self.get(index) - .ok_or(PkmnError::IndexOutOfBounds { index, len: self.len() }.into()) + .ok_or_else(|| PkmnError::IndexOutOfBounds { index, len: self.len() }.into()) } }