From 084ae841301e8991cf0fd7d61e1f0fc9f24cb551 Mon Sep 17 00:00:00 2001 From: Deukhoofd Date: Thu, 10 Jul 2025 22:41:56 +0200 Subject: [PATCH] Minor performance tweaks --- PkmnLib.Dynamic/AI/HighestDamageAI.cs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/PkmnLib.Dynamic/AI/HighestDamageAI.cs b/PkmnLib.Dynamic/AI/HighestDamageAI.cs index a9a9857..e0dba8c 100644 --- a/PkmnLib.Dynamic/AI/HighestDamageAI.cs +++ b/PkmnLib.Dynamic/AI/HighestDamageAI.cs @@ -25,11 +25,9 @@ public class HighestDamageAI : PokemonAI if (opponent == null) { var move = moves.FirstOrDefault(); - if (move != null) - { - return new MoveChoice(pokemon, move, opponentSide, 0); - } - return battle.Library.MiscLibrary.ReplacementChoice(pokemon, opponentSide, 0); + return move != null + ? new MoveChoice(pokemon, move, opponentSide, 0) + : battle.Library.MiscLibrary.ReplacementChoice(pokemon, opponentSide, 0); } var movesWithDamage = moves.Select(move => @@ -47,12 +45,12 @@ public class HighestDamageAI : PokemonAI Damage = battle.Library.DamageCalculator.GetDamage(null, move.MoveData.Category, pokemon, opponent, 1, 0, hitData), }; - }).OrderByDescending(x => x.Damage).ToList(); - if (movesWithDamage.Count == 0) + }).OrderByDescending(x => x.Damage).FirstOrDefault(); + if (movesWithDamage is null) { return battle.Library.MiscLibrary.ReplacementChoice(pokemon, opponentSide, 0); } - var bestMove = movesWithDamage.First().Move; + var bestMove = movesWithDamage.Move; return new MoveChoice(pokemon, bestMove, opponentSide, 0); }